streetwriters/notesnook

Moving editor tools around doesn't update indentation

Open

#4,350 创建于 2024年2月25日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)JavaScript (5,325 star) (285 fork)batch import
Platform: WebStatus: InvestigatingUnit: UI/UXgood first issue

描述

Really minor thing, doesn't break or cause a problem, just a UI glitch...

When moving an editor toolbar item out of a subgroup in to its parent, the indentation is still the same as if it were in the subgroup. (e.g. move code < > item out of subgroup 2 in to the main toolbar) It doesn't affect anything, and is fine when going out and back in to settings.

Device information: App version: 2.6.15-aa730b5-desktop OS: OS X 10.15.7 Browser: Electron 25.9.8 Pro: true

贡献者指南

技术栈
javascriptreact
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Familiarity with editor toolbar UI components
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
85
研究方向
The bug occurs when moving a toolbar item from a subgroup to the parent toolbar; the indentation does not update. Investigate the editor toolbar rendering logic, likely in the `editor` package or component. Check how indentation is calculated and whether it is re evaluated on item move. Look for any logic that sets indentation based on subgroup membership and ensure it triggers a re render or update when the parent changes. No existing PRs or comments provide further clues.