streamich/react-use

useEnsuredForwardedRef not working with callback refs

Open

#805 创建于 2019年11月26日

在 GitHub 查看
 (2 评论) (1 反应) (0 负责人)TypeScript (43,979 star) (3,273 fork)batch import
bughelp wanted

描述

If the forwarded ref is a callback ref the callback isn't called properly.

useEnsuredForwardedRef should check if the passed ref is a callback-function and if that's the case call it to set the ref.

贡献者指南

技术栈
typescriptreact
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Understanding React refsFamiliarity with useRef and forwardRef
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
85
研究方向
Examine the implementation of useEnsuredForwardedRef in the repository. The hook currently may not handle callback refs. To fix, add a check: if the forwarded ref is a function (callback ref), call it with the value instead of assigning to .current. Write unit tests to verify both object refs and callback refs work correctly.
useEnsuredForwardedRef not working with callback refs · streamich/react-use#805 | Good First Issue