streamich/react-use

Remove warnings from `useDeepCompareEffect`

Open

#755 创建于 2019年11月6日

在 GitHub 查看
 (8 评论) (0 反应) (0 负责人)TypeScript (43,979 star) (3,273 fork)batch import
buggood first issuehelp wanted

描述

Is your feature request related to a problem? Please describe.

useDeepCompareEffect gives warnings when using it with primitive dependencies. This is frustrating for the common case where dependencies could either undefined or an object that you'd like to be deep-compared.

Describe the solution you'd like

Remove warnings from useDeepCompareEffect or provide a way to suppress warnings.

贡献者指南

技术栈
typescriptreact
领域
frontend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
TypeScript basicsReact hooks
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Find the implementation of useDeepCompareEffect in the source code (likely in src/useDeepCompareEffect.ts). Examine the warning logic and decide whether to remove it or add a suppression option. Read the issue comments for guidance. Ensure any changes don't break existing tests.
Remove warnings from `useDeepCompareEffect` · streamich/react-use#755 | Good First Issue