storybookjs/storybook

[Bug]: optimizePackageImports do not work in @storybook/nextjs

Open

#30,126 创建于 2024年12月23日

在 GitHub 查看
 (2 评论) (1 反应) (0 负责人)TypeScript (89,909 star) (10,058 fork)batch import
bughelp wantednextjssev:S3

描述

Describe the bug

Some server code exported from barrel file. It works in nextjs itself because of optimizePackageImports, but fails to resolve some node packages in storybook.

Reproduction link

https://stackblitz.com/edit/github-dvxhuih6-cb6t3t3m?file=src%2Fshared%2Findex.ts

Reproduction steps

No response

System

System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 18.20.3 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.3 - /usr/local/bin/npm <----- active
    pnpm: 8.15.6 - /usr/local/bin/pnpm
  npmPackages:
    @storybook/addon-essentials: ^8.5.0-beta.4 => 8.5.0-beta.4 
    @storybook/addon-interactions: ^8.5.0-beta.4 => 8.5.0-beta.4 
    @storybook/addon-onboarding: ^8.5.0-beta.4 => 8.5.0-beta.4 
    @storybook/blocks: ^8.5.0-beta.4 => 8.5.0-beta.4 
    @storybook/nextjs: ^8.5.0-beta.4 => 8.5.0-beta.4 
    @storybook/react: ^8.5.0-beta.4 => 8.5.0-beta.4 
    @storybook/test: ^8.5.0-beta.4 => 8.5.0-beta.4 
    storybook: ^8.5.0-beta.4 => 8.5.0-beta.4

Additional context

No response

贡献者指南

技术栈
typescriptnextjsreact
领域
frontendtesting
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Next.jsStorybookTypeScriptbarrel files
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
This bug occurs because optimizePackageImports from Next.js is not applied in Storybook's webpack configuration, causing server side code to fail when imported from barrel files. To address, investigate how @storybook/nextjs merges the user's next.config.js (especially the experimental.optimizePackageImports field) into its own webpack config. The reproduction at StackBlitz shows the setup; check the shared/index.ts and see how the error arises. Look at the code in packages/storybook nextjs that handles webpack configuration merging, particularly the part that should respect nextConfig.experimental.optimizePackageImports. A potential fix would be to ensure that optimization is included in the final webpack config used by Storybook.
[Bug]: optimizePackageImports do not work in @storybook/nextjs · storybookjs/storybook#30126 | Good First Issue