storybookjs/storybook

[Bug]: experimental_indexers ignores importPath

Open

#25,554 创建于 2024年1月10日

在 GitHub 查看
 (15 评论) (0 反应) (1 负责人)TypeScript (89,909 star) (10,058 fork)batch import
buggood first issuehelp wantedsev:S3story index

描述

Describe the bug

In the experimental indexer docs it says that an indexer can specify an importPath to a target CSF file, but doing so has no effect. Looking at the source code it looks like the importPath returned from an indexer is not used and instead the input source to the indexer will always be used as the importPath.

To Reproduce

https://github.com/storybookjs/storybook/blob/e942e71e1f5281f9197faab6d61625b0ac8cecfd/code/lib/core-server/src/utils/StoryIndexGenerator.ts#L302

System

Storybook Environment Info:

  System:
    OS: macOS 14.2.1
    CPU: (10) arm64 Apple M1 Pro
    Shell: 5.1.16 - /opt/homebrew/bin/bash
  Binaries:
    Node: 20.10.0 - ~/.nvm/versions/node/v20.10.0/bin/node
    Yarn: 4.0.2 - ~/.nvm/versions/node/v20.10.0/bin/yarn <----- active
    npm: 10.2.3 - ~/.nvm/versions/node/v20.10.0/bin/npm
  Browsers:
    Chrome: 120.0.6099.109
    Edge: 120.0.2210.121
    Safari: 17.2.1

Additional context

No response

贡献者指南

技术栈
typescriptnodejs
领域
backendtooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
active
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
TypeScript basicsUnderstanding of Storybook's indexer concept
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
The bug is that experimental indexers ignore the importPath specified in the indexer configuration, and instead always use the input source as the importPath. The relevant code is in StoryIndexGenerator.ts around line 302. To fix this, examine how the indexer's returned importPath is handled and ensure it is used instead of the input source. Check the indexer documentation and the type definitions for experimental indexers to understand the expected behavior. Look at the function that processes indexers and verify where the importPath from the result is applied. The fix likely involves updating the logic to use the returned importPath when present.