storybookjs/storybook

[Bug]: Storybook launches in the wrong browser

Open

#22,929 创建于 2023年6月5日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)TypeScript (89,909 star) (10,058 fork)batch import
bugclihelp wantedsev:S4

描述

Describe the bug

On MacOS when my default browser is set to chrome, running start-storybook causes the storybook instance to launch in brave instead of chrome if both browsers are open.

To Reproduce

Open an instance of brave and chrome with chrome as your default browser. Run start-storybook and the storybook tab will be opened in brave instead of chrome.

System

Environment Info:

  System:
    OS: macOS 13.4
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
  Binaries:
    Node: 16.15.0 - ~/.nvm/versions/node/v16.15.0/bin/node
    Yarn: 3.5.0 - ~/codebase/sf-ui-web/node_modules/.bin/yarn
    npm: 8.5.5 - ~/.nvm/versions/node/v16.15.0/bin/npm
  Browsers:
    Chrome: 114.0.5735.90
    Safari: 16.5

Additional context

No response

贡献者指南

技术栈
typescriptnodejsshell
领域
frontenddeveloper experiencetooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Node.js basicsStorybook CLImacOS browser management
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Investigate the start storybook command's browser opening logic. Look for calls to `open` or `opn` package in the Storybook source code. The bug likely occurs because the browser detection does not respect the system default browser when multiple browser instances are open. Check the macOS specific implementation in the `@storybook/core server` or `@storybook/cli` package for browser launching code. Consider using the `open` npm package or the `x www browser` approach on macOS.