storybookjs/storybook

[Feature Request]: CSF3 Autofixer shouldn't hoist arg uses above declarations

Open

#21,488 创建于 2023年3月8日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)TypeScript (89,909 star) (10,058 fork)batch import
bugcodemodshelp wantedsev:S3

描述

Is your feature request related to a problem? Please describe

When migrating a story defined like:

export const MyStory = (props) => <MyComponent {...props} />
const defaultArgs = { foo: 'bar'}
MyStory.args = defaultArgs

using the args is hoisted above the constant definition:

export const MyStory = {
  render: (props) => <MyComponent {...props} />,
  args: defaultArgs,
}
const defaultArgs = { foo: 'bar'}

Describe the solution you'd like

Ideally the codemod would move the constant declaration above where it was used:

const defaultArgs = { foo: 'bar'}
export const MyStory = {
  render: (props) => <MyComponent {...props} />,
  args: defaultArgs,
}

Describe alternatives you've considered

I looked, but there's not an autofixer for this in eslint or ts. I can check to see if theres an existing codemod that can help with this.

Are you able to assist to bring the feature to reality?

yes, I can

Additional context

No response

贡献者指南

[Feature Request]: CSF3 Autofixer shouldn't hoist arg uses above declarations · storybookjs/storybook#21488 | Good First Issue