storybookjs/storybook

[Bug]: Automigration addReact fails with `package.json` overrides

Open

#21,271 创建于 2023年2月27日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)TypeScript (89,909 star) (10,058 fork)batch import
bugclihelp wantedsev:S3

描述

Describe the bug

Error:
npm ERR! code EOVERRIDE
npm ERR! Override for react@* conflicts with direct dependency
npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/xxx/.npm/_logs/2023-02-23T13_19_13_353Z-debug-0.log

Summary: The package.json has a overrides field, which defines react:

"overrides": {
	"react": "^18.0.0"
}

This hinders the addReact automigration to run and the sb upgrade script aborts. The error also leads for sb init to fail, because React is installed automatically without asking the user.

To Reproduce

https://github.com/bitwarden/clients per @valentinpalkovic

System

No response

Additional context

No response

贡献者指南

技术栈
javascripttypescriptreactnodejs
领域
developer experiencetooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic knowledge of npm package.jsonUnderstanding of npm overrides
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
Investigate the automigration code that adds React dependency, likely in the Storybook CLI's addReact function. Reproduce the error using the repository linked in the issue. The fix likely involves checking for existing 'overrides' field in package.json and either merging or skipping the automigration if a conflict arises. Look for the relevant source files in the monorepo, such as in the 'cli' or 'automigrate' directories.