stevenbenner/jquery-powertip

Crash When Showing but No Active Hover: Cannot read properties of null (reading 'data')

Open

#184 创建于 2023年1月15日

在 GitHub 查看
 (12 评论) (0 反应) (0 负责人)JavaScript (820 star) (144 fork)batch import
BugHelp Wanted

描述

I came across a crash while hovering over a number of items that have powertips. This is some sort of open/close race condition, because it doesn't happen often, although I can reproduce it somewhat easily.

The error message is: Cannot read properties of null (reading 'data')

The image below illustrates the moment of the crash, the tip is open, but there is no active hover. Can it simply be fixed by changing:

				if (!session.isClosing) {
					hideTip(session.activeHover);
				}

to

				if (!session.isClosing && session.activeHover) {
					hideTip(session.activeHover);
				}

Using version 1.3.2

image

image

Callstack

hideTip (jquery.powertip.js:1021)
showTip (jquery.powertip.js:912)
queueTipInit (jquery.powertip.js:886)
dequeue (jquery.js)
r.complete (jquery.js)
l (jquery.js)
add (jquery.js)
Kn (jquery.js)
o (jquery.js)
dequeue (jquery.js)
o (jquery.js)
queueTipInit (jquery.powertip.js:887)
dequeue (jquery.js)
o (jquery.js)
queueTipInit (jquery.powertip.js:887)
dequeue (jquery.js)
r.complete (jquery.js)
l (jquery.js)
fireWith (jquery.js)
a (jquery.js)
v.fx.tick (jquery.js)
setInterval (async)
v.fx.timer (jquery.js)
Kn (jquery.js)
o (jquery.js)
dequeue (jquery.js)
o (jquery.js)
queueTipInit (jquery.powertip.js:887)
dequeue (jquery.js)
(anonymous) (jquery.js)
each (jquery.js)
each (jquery.js)
queue (jquery.js)
beginShowTip (jquery.powertip.js:885)
openTooltip (jquery.powertip.js:505)
apiShowTip (jquery.powertip.js:251)
show_docket_tip (user_code)

贡献者指南

技术栈
javascript
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
1
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
active
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic JavaScript
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
90
研究方向
The bug is in jquery.powertip.js at the hideTip call. The user suggests adding a null check for session.activeHover before calling hideTip(). This is a simple, localized fix. Review the code around line 1021 and confirm the proposed change resolves the race condition without side effects.
Crash When Showing but No Active Hover: Cannot read properties of null (reading 'data') · stevenbenner/jquery-powertip#184 | Good First Issue