stan-dev/stan

Remove unused variational::base_family class

Open

#1,695 创建于 2015年11月19日

在 GitHub 查看
 (4 评论) (0 反应) (1 负责人)R (1,476 star) (270 fork)batch import
code cleanupgood first issue

描述

The base class variational::base_family has no virtual methods and the one function it does define uses no member variables or functions, so can be made standalone outside of the class. Therefore, base_family should be removed.

  • remove src/stan/variational/base_family.hpp
  • move function write_error_msg_() into its own file and rename without suffix _
  • patch families/normal_meanfield.hpp and families/normal_fullrank.hpp:
    • remove references to base_family
    • change calls to write_error_msg_ to include and call new function

If the intent was to somehow pull down some of the functionality from the subclasses, then this issue should be repurposed to do that.

贡献者指南

技术栈
cpp
领域
backend
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
C++Stan code organization
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
The issue specifies three tasks: remove src/stan/variational/base family.hpp, create a new file for write error msg () without the underscore suffix, and update families/normal meanfield.hpp and families/normal fullrank.hpp to remove base family references and call the new function. The main question from the issue is whether the base family class was intended to pull down functionality from subclasses, which should be clarified with maintainers. The files are in the stan/variational directory.