srid/haskell-flake

Add `cabal check` to `checks`

开放

#50 创建于 2022年12月1日

 (0 条评论) (0 个反应) (0 位负责人)Nix (26 个派生)github user discovery
enhancementgood first issue

仓库指标

星标
 (231 个星标)
PR 合并指标
 (平均合并 9小时 49分钟) (30 天内合并 1 个 PR)

描述

In arion I had a separate build with

                  checked = super.haskell.lib.overrideCabal pkg (o: {
                    postConfigure = ''${o.postConfigure or ""}
                      if ! ${hsuper.cabal-install}/bin/cabal check;
                      then
                        echo 1>&2 ERROR: cabal file is invalid. Above warnings were errors.
                        exit 1
                      fi
                    '';
                  });

I think we could touch the outputs and exit 0 to speed this up. Doing it in runCommand would be fragile. This should probably call Setup.hs instead of cabal-install.

Running it as part of the main build isn't ideal because the check may be more strict than necessary. I think it should only run in CI.

贡献者指南