spring-cloud/spring-cloud-gateway

Modify Request Body for a GET request

Open

#1,147 创建于 2019年7月3日

在 GitHub 查看
 (7 评论) (0 反应) (0 负责人)Java (4,284 star) (3,204 fork)batch import
enhancementhelp wanted

描述

We currently have custom code for modifying request body which works but I want to move to the standard ModifyRequestBodyGatewayFilterFactory.

We have a scenario where Spring Cloud Gateway received a GET request and we need call an internal GraphQL api with a POST and a request body.

ModifyRequestBodyGatewayFilterFactory works great if there is a body present in the original request but doesn't apply the rewriteFunction when there is no body on GET requests.

I am using v2.1.2.RELEASE and I have hacked together a change to ModifyRequestBodyGatewayFilterFactory which works for me:

Mono<?> modifiedBody = serverRequest.bodyToMono(inClass)
        .defaultIfEmpty("") //added this line
        .flatMap(o -> config.rewriteFunction.apply(exchange, o));

I appreciate that the ModifyRequestBodyGatewayFilterFactory is beta, but would it be possible to support adding a body for GET requests in the future?

贡献者指南

技术栈
javaspringgraphql
领域
backendapi
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
JavaSpring Cloud GatewayReactive programming
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
Examine the current implementation of `ModifyRequestBodyGatewayFilterFactory` in the spring cloud gateway repository. The user's proposed fix is to add `.defaultIfEmpty("")` in the `filter` method to allow body rewriting when original request body is empty (typical for GET requests). Implement this change and ensure it does not break existing behavior for POST requests with a body. Write unit tests covering both scenarios and verify the filter works with the standard `ModifyRequestBodyGatewayFilterFactory`. Refer to the linked issue for additional context on the expected behavior.