spotify/reactochart

resolvers in `resolveXYScale` should recursively traverse `children` tree

开放

#36 创建于 2017年1月6日

 (1 条评论) (0 个反应) (0 位负责人)JavaScript (50 个派生)auto 404
help wanted

仓库指标

星标
 (554 个星标)
PR 合并指标
 (30 天内没有已合并 PR)

描述

The new code in 0.2.1 is improving but has a significant regression - All of the resolvers in resolveXYScales used to recursively check the component's children to find the necessary props. However @thehindenburg 's new mapOverChildren, while being a nicer abstraction, does not do recursion - it only maps over an element's direct children.

Recursion is necessary IMHO because we want to support the use case of the user having intermediate layer components between XYPlot and their charts, eg.:

<XYPlot>
  <CustomChartWrapper>
    <LineChart />
    <AreaChart />
    <BarChart />
  </CustomChartWrapper>
</XYPlot>

Without recursion, this would never try to resolve anything on the actual chart components, it would stop at CustomChartWrapper. We should improve the general resolution functions in resolveXYScales to handle this case

贡献者指南