spotify/docker-client

listTasks should allow list of values in each filter

Open

#1,092 创建于 2018年10月4日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)Java (1,430 star) (551 fork)batch import
bughelp wantedpinned

描述

Description

bug report

How to reproduce

The implementation of listTasks(Task.Criteria) here https://github.com/spotify/docker-client/blob/e1c7d47f778ec9c7e80279ecae812bf2098d4b34/src/main/java/com/spotify/docker/client/DefaultDockerClient.java#L2057 only allows one value for each filter. API docs state the value of each filter can be a list.

What do you expect

Allow a list of strings for each filter.

Software:

  • docker version: API 1.24+
  • Spotify's docker-client version: all

贡献者指南

技术栈
javadocker
领域
backendapi
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
JavaDocker APIList data structures
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Start by examining the `listTasks(Task.Criteria)` method in `DefaultDockerClient.java` (line 2057). Understand how filters are currently restricted to a single value per key. Modify the method and the `Task.Criteria` class to accept a list of values for each filter, ensuring compliance with Docker API v1.24+. Update the REST call to pass the list correctly. Test the change with multiple filter values.
listTasks should allow list of values in each filter · spotify/docker-client#1092 | Good First Issue