spiffe/spire

Fix the "expiring" and "outdated" metrics emitted during entry sync to be accurate across the whole cache

开放

#2,437 创建于 2021年8月3日

 (8 条评论) (0 个反应) (0 位负责人)Go (631 个派生)auto 404
help wantedpriority/backlog

仓库指标

星标
 (2,443 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

Ref https://github.com/spiffe/spire/blob/04bee9741ac3b8c4b204e6367d0bd6146f78a8c7/pkg/agent/manager/sync.go#L67

	// TODO: this values are not real, we may remove
	if expiring > 0 {
		telemetry_agent.AddCacheManagerExpiredSVIDsSample(m.c.Metrics, float32(expiring))
		m.c.Log.WithField(telemetry.ExpiringSVIDs, expiring).Debug("Updating expiring SVIDs in cache")
	}
	if outdated > 0 {
		telemetry_agent.AddCacheManagerOutdatedSVIDsSample(m.c.Metrics, float32(outdated))
		m.c.Log.WithField(telemetry.OutdatedSVIDs, outdated).Debug("Updating SVIDs with outdated attributes in cache")
	}

It's not clear what is meant by "[these] values are not real" and why (I'm assuming) the metric blocks may be removed?

  • If this logic or similar may be removed, let's go ahead and remove it for this issue
  • If removal can't be done yet, let's update that comment to be more specific, and add a github issue number tracking removal
  • If the removal can't or is not foreseen as ever removable, let's get rid of the comment

贡献者指南