spencermountain/spacetime

i18n `.since()`

Open

#110 创建于 2019年3月18日

在 GitHub 查看
 (5 评论) (0 反应) (0 负责人)JavaScript (3,809 star) (189 fork)batch import
enhancementfixed-on-devhelp wantedready

描述

Seems like the since method's output is hardcoded to English? https://github.com/spencermountain/spacetime/blob/8b93859d23cfd828dca7de50cc8ec72105393cf4/src/methods/since.js#L132

Any thoughts on allowing i18n as per the custom languages example?

贡献者指南

技术栈
javascriptnodejs
领域
internationalizationlocalization
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Familiarity with spacetime's custom language systemJavaScript basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
Examine the file src/methods/since.js around line 132 to understand how the 'since' method currently outputs hardcoded English strings. Review the existing custom language implementation (e.g., in src/languages) to see how other methods localized their output. Propose changes to 'since' to accept a language parameter or use the library's default language, and provide an example of how to add translations for the relative time phrases.