spec-first/connexion

Allow passing of a Specification object to AbstractApp.add_api

Open

#1,260 创建于 2020年6月26日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)Python (4,346 star) (738 fork)batch import
enhancementgood first issue

描述

Description

Right now you can pass either a file path to a JSON swagger spec, or a parsed dictionary of one.

Expected behaviour

It would be nice if you could pass in a Specification object, since they can be quite expensive to create even from a dictionary - as much as 10s for ours! Enabling this could speed up startup times for large apps, as well as aid in testing where apps are created over and over.

Actual behaviour

It doesn't do allow this :) People instead monkeypatch (eg. https://github.com/zalando/connexion/issues/306#issuecomment-584258868) to work around this which is never ideal.

贡献者指南

技术栈
python
领域
backendapi
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic Python knowledgeFamiliarity with connexion library
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Examine the current implementation of `AbstractApp.add api` in the connexion source code, likely in `connexion/app.py`. Understand how it currently accepts a file path or dict. Determine the structure of a `Specification` object and modify the method to accept it as an alternative input, handling the creation path accordingly. Test the change with examples from the issue.