sourcegraph/sourcegraph-public-snapshot

Fix selection after running a settings quick action

开放

#2,756 创建于 2019年3月15日

 (8 条评论) (0 个反应) (2 位负责人)Go (1,374 个派生)auto 404
bugfrontend-platformgood first issuewebapp

仓库指标

星标
 (10,290 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

The settings quick actions (the buttons on the global/org/user settings JSON editor pages) yield the wrong selection after clicking them in some cases. The selection should be the newly added line, but it instead is the line above.

This only occurs for actions (such as setSearchContextLines) that DO NOT specify a selection text.

This is because the selection is computed as:

                    selection = monaco.Selection.fromPositions(
                        monacoEdits[0].range.getStartPosition(),
                        monacoEdits[monacoEdits.length - 1].range.getEndPosition()
                    )

and this breaks when the edit needs to add a trailing comma to the preceding line.

贡献者指南