someshkar/covid19india-cluster

Highlighting the Patient Number Searched

Open

#177 创建于 2020年3月30日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)JavaScript (991 star) (666 fork)batch import
good first issue

描述

Hi! While this looks amazing, calling out a small issue that I felt while searching patient was as follows:

  • The resolution of the graph can be reduced a little, often the patient searched goes out of screen (SS-1 as below), image I had to zoom out manually to see the search result. (SS-2 as below) image

  • The Patient searched can be highlighted with a light background color as well to enhance the visiblity.

贡献者指南

技术栈
javascript
领域
frontend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
basic understanding of graph rendering in JavaScript
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Look at the graph component files, likely in the src directory, to understand how patient nodes are rendered and zoom is handled. The issue requests two changes: reducing graph resolution to prevent the searched patient from going off screen, and highlighting the searched patient with a light background. Consider adjusting the camera/zoom behavior to center on the selected node, and adding a CSS class or style to highlight the node. Check if there are any existing similar implementations or comments from maintainers.