solana-labs/solana

Balances are collected for transactions within a TransactionBatch that aren't locked or executed

Open

#32,346 创建于 2023年6月30日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)Rust (12,651 star) (3,950 fork)batch import
communityenhancementgood first issuevalidator

描述

Problem

When collecting balances before and after execution in BankingStage, the balances for transactions within a TransactionBatch that didn't execute still get collected even though the state didn't change.

There is likely a slight performance hit for doing this, especially with batches that contain many transactions that failed to lock.

Proposed Solution

When collecting pre-balances, check the lock results and only collect pre-balances for transactions that lock successfully. When collecting post-balances, check the execution results and only collect post-balances for transactions that executed.

贡献者指南

技术栈
rust
领域
performanceblockchain
议题类型
performance
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
RustSolana BankingStageTransaction batch processing
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
35
研究方向
Start by exploring the BankingStage code in the Solana repository, likely under 'runtime/src/banking stage.rs' or similar. Look for where pre balances and post balances are collected, and understand how TransactionBatches are processed. Then implement the proposed check to skip balance collection for transactions that did not lock or execute. Refer to the issue comments for any further context.