solana-labs/solana

Decouple metrics submission from RUST_LOG

Open

#15,215 创建于 2021年2月9日

在 GitHub 查看
 (14 评论) (6 反应) (1 负责人)Rust (12,651 star) (3,950 fork)batch import
good first issue

描述

Problem

It is occasionally desired to reduce text log size, but continue submitting full metrics. With metrics level taken from RUST_LOG, this is not possible.

Relevant Code

Datapoints are pushed to the MetricsAgent based on log level here: https://github.com/solana-labs/solana/blob/d4ce59eee7e2537f02c827b6918de9af559b06bd/metrics/src/datapoint.rs#L153-L165

If the datapoint has sufficient log-level based on RUST_LOG to get submitted, then it will eventually reach here where it is both logged to file and pushed into a vector to be sumitted. https://github.com/solana-labs/solana/blob/d4ce59eee7e2537f02c827b6918de9af559b06bd/metrics/src/metrics.rs#L261-L264

Proposed Solution

Look into the feasibility of decoupling metrics from RUST_LOG

贡献者指南

技术栈
rust
领域
observabilityperformance
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
blocked
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
RustSolana metrics module
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
45
研究方向
Investigate the metrics submission flow in metrics/src/datapoint.rs and metrics/src/metrics.rs. Understand how datapoints are filtered by log level via RUST LOG. Explore adding a separate configuration mechanism (e.g., an environment variable) to control minimum log level for metrics independently. Review existing comments in the issue for any design constraints or rejected approaches.