solana-labs/solana

Would you support the "pong" response in websocket api when receiving "ping"?

Open

#15,187 创建于 2021年2月8日

在 GitHub 查看
 (7 评论) (3 反应) (0 负责人)Rust (12,651 star) (3,950 fork)batch import
good first issue

描述

Problem

I connect to my own solana node via websocket, but I found It seems not provide a complete heartbeat flow (send ping then get pong). imho, a pong not only a server response, also a network performance. I can know there is something wrong via a late response time.

Proposed Solution

Just like other api do, response a struct {"jsonrpc":"2.0","result":"pong","id": 1} or something like that.

贡献者指南

技术栈
rust
领域
apiblockchain
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Basic understanding of WebSocket protocolFamiliarity with Solana RPC
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
Investigate the websocket handling code in the Solana node, likely in the RPC or pubsub modules. Look for existing ping handling and implement pong response similar to JSON RPC 2.0. A good starting point is the `solana rpc` crate and its websocket subscription handlers. Check if there is any prior discussion in the comments about implementation details.