solana-labs/solana

Missing invoke translation test

Open

#13,955 创建于 2020年12月4日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)Rust (12,651 star) (3,950 fork)batch import
good first issueruntime

描述

Problem

Missing a test that verifies the AccountInfo's data length is correctly enforced to exist in RW data. The length is translated correctly but we have no way to ensure that it will continue to do so over time.

https://github.com/solana-labs/solana/blob/5dceddd21d3c1cf874b003a0c25b1f21f4926614/programs/bpf/rust/ro_modify/src/lib.rs#L158

Proposed Solution

AccountInfo's data is expressed as an Rc<RefCell<&mut [u8]>>, need a way to construct this where the slice's len is in RO memory (like the RO segment of a BPF ELF) while the data pointer points to RW memory. This is not a use case that can be activated without malicious intent.

贡献者指南

技术栈
rust
领域
testing
议题类型
test
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
4
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
RustSolana BPFRc<RefCell>memory segments
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
20
研究方向
The issue requires writing a test that constructs an Rc<RefCell<&mut [u8]>> where the slice's length is in RO memory (like the RO segment of a BPF ELF) while the data pointer points to RW memory. Refer to the linked file in solana/programs/bpf/rust/ro modify/src/lib.rs for context. Investigate how to simulate this memory layout in a test environment, possibly by using unsafe code or existing testing utilities. Examine similar tests in the same repository for patterns.