smpallen99/coherence

Decoupling controller functionality

Open

#324 创建于 2018年1月17日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)Elixir (1,259 star) (220 fork)batch import
enhancementhelp wanted

描述

Hey,

I'm very interested in coherence and the functionality it provides, however, I'd like to experiment with combining its functionality with other frameworks, for example ueberauth, or just in the case where I would like to use my customer controllers.

I have noticed that a lot of the meat is inside the coherence controllers, for example in order to fully create a new session you require to use Coherence.SessionController.create/2. Would it be a good idea to separate this functionality into a separate module so it could be used outside of coherence?

If this seems sensible I could start with a PR to pull out session functionality? I'm not 100% sure what the *_service.ex modules are intended for, but this would be a place I'd refactor the functionality to.

How does this sound?

贡献者指南

技术栈
elixir
领域
backendauthentication
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Elixir knowledgePhoenix controllers experienceCoherence codebase understanding
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
The issue proposes refactoring Coherence.SessionController.create/2 into a separate module. Review existing * service.ex modules to identify current patterns. Consult maintainer feedback from the single comment and examine how similar frameworks handle controller separation. Focus on extracting session logic first.