smpallen99/coherence

Rememberable in last git version.

Open

#279 创建于 2017年9月12日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)Elixir (1,259 star) (220 fork)batch import
bughelp wanted

描述

Hello. I have two problems with rememberable in last git version.

  • If I use my own user_schema in Config, it works ok evereywhere, when is used as declared, except in Rememberable.eex Schema, when is used: belongs_to :user, Module.concat(Config.module, Config.user_schema) This is inconsistent with rest of uses, for example in controllers: defp rememberable_enabled? do if Config.user_schema.rememberable?(), do: true, else: false end Where is not concatenated with the module.

  • Second, I want to use just a Rememberable Schema (as I do with user) declaring it in Config in order to reuse the same schema in some apps. But in controllers Rememberable is obtained using Coherence.Schemas.schema(Rememberable), and not from config.

    def schema(schema) do Module.concat [Config.module, Coherence, schema] end

So I can't reuse the Rememberable schema.

Thanxs in advance.

贡献者指南

技术栈
elixir
领域
authenticationbackend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic Elixir knowledgeCoherence configuration familiarityPhoenix framework basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
45
研究方向
First, clone the coherence repository and examine lib/coherence/schemas.ex to understand how Module.concat is used for schemas. Compare it with the usage of Config.module and Config.user schema in other files like controllers. Note the inconsistency: in controllers, Config.user schema.rememberable?() is called directly without concatenation, but in Rememberable.eex Schema it uses Module.concat(Config.module, Config.user schema). Investigate how the Rememberable schema is obtained via Coherence.Schemas.schema(Rememberable) and why it doesn't use the config. The goal is to make Rememberable schema configurable and reusable. Look for existing config options like user schema and consider adding a rememberable schema option. Consult the coherence documentation and config files for patterns to follow.