slackapi/hubot-slack

SlackBot#send() support for a callback function

Open

#473 创建于 2018年4月13日

在 GitHub 查看
 (0 评论) (6 反应) (0 负责人)CoffeeScript (2,339 star) (637 fork)batch import
enhancementgood first issue

描述

Description

in order to know anything about a message after it has been sent, there needs to be a way to run a callback after the chat.postMessage() method completes.

it seems that the Response#send() (from Hubot core) method will invoke the adapter's send() method with the final item in the messages... array set to a function, if the user's script specified one.

this means that all we need to do is pass that callback function into the SlackClient#send() method and make sure it's used as the callback (we can set a default value of a noop function if not).

this support should also be extended to reply() and setTopic().

this would unlock use cases such as #91

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.

贡献者指南

技术栈
nodejsjavascript
领域
apibackend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Understanding of Hubot adapter patternBasic JavaScript/Node.js
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Look at the send method in the SlackBot adapter (likely in src/slackbot.coffee). Implement a callback parameter that defaults to a noop function and pass it to the underlying SlackClient.send() call. Also update reply() and setTopic() similarly. Refer to Hubot's documentation on Response#send for how the callback is passed.