Sinon fails in comparing call order when running tests in parallel · sinonjs/sinon#2472

(11 评论) (0 反应) (0 负责人)JavaScript (9,548 star) (764 fork)batch import

BugDifficulty: EasyHelp wantedImprovementgood first issue

描述

Describe the bug

spy1.calledImmediatelyBefore(spy2) fails when used in a node-tap test suite that is being executed in parallel. In serial mode it works without issue. calledBefore continues to work as normal.

I've even tried using sandboxes for each test but it did not fix the issue.

To Reproduce

Repo: https://github.com/Ethan-Arrowood/sinon-spy-parallel-bug-reproduction

git clone https://github.com/Ethan-Arrowood/sinon-spy-parallel-bug-reproduction
cd sinon-spy-parallel-bug-reproduction
pnpm install
pnpm run test

To see tests passing comment out line 27 in test/index.ts:

+ // tap.jobs = 2;
- tap.jobs = 2;

Expected behavior

I'd expect my spy assertions to pass in both serial and parallel mode

Context (please complete the following information):

Library version: 14.0.0
Environment: Node.js 18
Example URL:
Other libraries you are using: node-tap, typescript

贡献者指南

技术栈: javascripttypescript
领域: testing
议题类型: bug
难度: 3
预计时间: 1-3 hours
活动状态: stale
清晰度: clear
前置要求: Understanding of Sinon spy APIFamiliarity with node tap parallel testsBasic knowledge of JavaScript testing
新手友好度: 40
研究方向: Examine the Sinon source code, specifically the implementation of `calledImmediatelyBefore` and related call order tracking methods. Look at how spies manage call history in sandboxes, especially when tests run concurrently. The reproduction repository (https://github.com/Ethan Arrowood/sinon spy parallel bug reproduction) provides a minimal failing test. Investigate whether there's a race condition or shared state between parallel test runs. Consider if the issue stems from how Sinon assigns unique identifiers to spies or how it timestamps calls. Check existing discussions in the issue for any hints or proposed fixes.