sinonjs/sinon

Name differences

Open

#1,509 创建于 2017年8月3日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)JavaScript (9,548 star) (764 fork)batch import
Difficulty: MediumHelp wantedhacktoberfestpinned

描述

It might be logical reasons that I don't know about, but I wonder about some of the name differences between sinon-methods:

spy.notCalledWith assert.neverCalledWith

Should they have the same name?

stub.callsFake stub.callsArg stub.callsArgWith stub.callThrough stub.callArg stub.callArgWith

I often end up checking the docs where there is 'calls*' and where there is 'call*'.

贡献者指南

技术栈
javascript
领域
testing
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
JavaScriptsinon API basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Review the current sinon API documentation and source code for the listed methods (notCalledWith, neverCalledWith, callsFake, callsArg, etc.) to understand the naming conventions. Then propose a consistent naming scheme and potentially submit a PR to rename methods or add aliases. Check the issue comments for any prior discussion.
Name differences · sinonjs/sinon#1509 | Good First Issue