sindresorhus/update-notifier

Run in child process instead of lazy loading every dependency

Open

#210 创建于 2021年7月26日

在 GitHub 查看
 (4 评论) (0 反应) (0 负责人)JavaScript (1,800 star) (164 fork)user submission
enhancementhelp wanted

描述

Not a big fan [of lazy loading], but I've seen update-notifier as a require time offender when profiling various things. The idea of update-notifier is that it should have no impact on the consumer. It's just an added bonus, not critical. https://github.com/yeoman/update-notifier/pull/82#issuecomment-225636213

I may be wrong, it seems to me that this change was made simply to hide the package from the very initial load but in practice every dependency is still loaded right after.

update-notifier already uses a child process to do the checking, so I think it'd be best to do the whole thing there.

Related:

贡献者指南

技术栈
javascriptnodejs
领域
cliperformance
议题类型
performance
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Node.js child processesupdate notifier internals
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
Review the current implementation in index.js, especially the child process call at line 98. Understand how lazy loading currently works by examining the require statements. Then, design a solution where the entire update check logic runs in a child process, so dependencies are not loaded in the main process. Consider testing and edge cases.