sindresorhus/type-fest

`PartialDeep` make `Date` internal structure partial

Open

#719 创建于 2023年10月20日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)TypeScript (12,328 star) (471 fork)batch import
buggood first issuehelp wanted

描述

I've noticed that when you apply PartialDeep to something containing Date it makes the Date internal structure partial, which causes some errors when combining it with zod validations for instance.

Should it skip internal JS classes like Date while making something partially deep?

I've found https://github.com/sindresorhus/type-fest/pull/342, but I still see the issue on version v4.4.0, might be a regression?

贡献者指南

技术栈
typescript
领域
developer experiencetooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
TypeScript type systemdeep partial types
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
Investigate the implementation of `PartialDeep` in `source/partial deep.ts` and how it handles `Date` objects. Refer to the referenced PR #342 which attempted to address this issue. Check if the current behavior is a regression and consider adding a condition to skip built in types like `Date` when applying deep partial.