Show count for Inbox, not Unread · sindresorhus/notifier-for-github#238

(0 评论) (4 反应) (0 负责人)JavaScript (1,965 star) (144 fork)user submission

enhancementhelp wanted

描述

I use an "inbox zero" approach with Github notifications, in which my notifications are marked Done when I have no further use for them, and unread notifications don't have much meaning to me. This is also the default view in Github, at least for me — I had opted into the new notifications beta on Github a while back, I'm not sure if that's still affecting what I see.

Would it be possible to provide an option of counting notifications that aren't done (what the Inbox view shows) rather than the unread count? I suppose you could generalize this to show the count resulting from some arbitrary query, but I don't personally need that.

I realize this is somewhat like https://github.com/sindresorhus/notifier-for-github/issues/171, but I believe the idea may be worth considering again in light of Github's notification overhaul in November 2019.

贡献者指南

技术栈: javascript
领域: frontenddeveloper experience
议题类型: feature
难度: 3
预计时间: half day
活动状态: stale
清晰度: clear
前置要求: JavaScriptbrowser extension development
新手友好度: 70
研究方向: The current badge count is likely computed in the background script by calling the GitHub API with the 'unread' parameter. To implement this feature, you would need to modify the API call to fetch notifications that are not marked as 'done' (inbox view) instead. Research how GitHub's notification API handles inbox vs unread. Look at the codebase for the function that fetches notification counts (e.g., in background.js or similar). Consider adding a user option to toggle between unread and inbox count, and update the badge accordingly.