sindresorhus/notifier-for-github

Notifier stays offline despite regaining connection

Open

#132 创建于 2017年6月8日

在 GitHub 查看
 (12 评论) (3 反应) (0 负责人)JavaScript (1,965 star) (144 fork)user submission
:dollar: Funded on Issuehuntbughelp wanted

描述

When Chrome goes offline and the extension looses connection to Github, it shows a yellow text bubble saying off (or something similar). When you regain internet connection, this bubble stays in place and the only way to reconnect is to manually click on the plugin icon. I have had the plugin be in 'offline' mode for long periods of time and therefore missed notifications.

Ideally, the plugin would re-connect itself and not require the user to click on the plugin icon to reconnect to Github. Not very familiar with the Chrome API but if it does not expose a method to be notified upon regaining internet connection, something like a setTimeout that pings the URL every 5 seconds until a connection could be another solution.

@sindresorhus Any thoughts? I will create a PR if you will accept it.


Backers (Total: $40.00)

Submitted pull Requests


Become a backer now!

Or submit a pull request to get the deposits!

Tips

贡献者指南