sindresorhus/memoize

Warn when `cacheKey` is unset and `function.length > 1`?

Open

#90 创建于 2023年2月1日

在 GitHub 查看
 (6 评论) (0 反应) (0 负责人)TypeScript (1,155 star) (55 fork)user submission
enhancementhelp wanted

描述

By default, only the memoized function's first argument is considered via strict equality comparison

I think mem should call console.warn in this case:

mem(async (host, path) => fetch(host + path))

Correct usage:

mem(async (host, path) => fetch(host + path), {
  cacheKey: args => args.join()
})

mem(async (host, path) => fetch(host + path), {
  cacheKey: JSON.stringify
})

贡献者指南

技术栈
javascripttypescriptnodejs
领域
developer experience
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
JavaScriptNode.jsTypeScript
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
80
研究方向
Examine the main source file (likely index.ts) to locate the memoize function implementation. Add a conditional check: if the memoized function has more than one argument (function.length > 1) and no custom cacheKey option is provided, output a one time warning using console.warn explaining the default behavior and suggesting to provide a cacheKey. Write tests to verify the warning is emitted only when appropriate, and update any relevant documentation.