sindresorhus/linkify-urls

Parentheses in URLs break linkifying

Open

#28 创建于 2017年11月7日

在 GitHub 查看
 (5 评论) (0 反应) (0 负责人)JavaScript (173 star) (23 fork)user submission
bughelp wanted

描述

@fregante edit: Issue transferred from refined-github. This issue still happens in v3.1.0

See this line:

The URL contains parentheses which make the anchor cut off the URL in both the href and the visual link producing a wrong URL.

Original valid URL:

https://github.com/jserz/js_piece/blob/master/DOM/ParentNode/append()/append().md

贡献者指南

技术栈
javascript
领域
tooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic regex knowledgeJavaScript
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Investigate the current regex pattern used in the linkify urls library (likely in index.js) that fails to include parentheses in URLs. Look at the examples provided in the issue, such as 'https://github.com/jserz/js piece/blob/master/DOM/ParentNode/append()/append().md', to understand the failing case. The fix may involve modifying the regex to allow parentheses or escaping them properly. Check if any PRs or comments suggest a solution.