sindresorhus/eslint-plugin-unicorn

consistent-function-scoping should ignore jest mocks

Open

#805 创建于 2020年8月4日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)JavaScript (5,022 star) (468 fork)user submission
enhancementhelp wanted

描述

Using jest.mock() does not work properly with consistent-function-scoping as it's not allowed to reference any out of scope variables as mocked function.

ReferenceError: /__tests__/search.spec.tsx: The module factory of `jest.mock()` is not allowed to reference any out-of-scope variables.

jest.mock("next/dynamic", () => () => "dynamic-drawer");

贡献者指南

技术栈
javascripttypescript
领域
toolingtesting
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
understanding of ESLint plugin developmentfamiliarity with jest.mock()
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Locate the consistent function scoping rule implementation in rules/consistent function scoping.js. Understand how it checks for out of scope variables. The issue is that jest.mock factory functions are allowed to reference variables that are actually in scope (module level), but the rule incorrectly flags them. Look for where the rule evaluates function expressions or callbacks and add an exception for jest.mock() calls. Check existing tests for this rule to understand expected behavior.