sindresorhus/eslint-plugin-unicorn

Rule proposal: Prefer `String#matchAll()`

Open

#574 创建于 2020年3月3日

在 GitHub 查看
 (6 评论) (5 反应) (0 负责人)JavaScript (5,022 star) (468 fork)user submission
help wantednew rule

描述

Not offering a PR here, but just thought such a rule could possibly fit your project...

Namely, preferring String.prototype.matchAll to while loop exec assignments.

As per https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/matchAll#Examples , one can replace this:

let match;
while ((match = regexp.exec(str)) !== null) {
}

..with the likes of:

for (const match of str.matchAll(regexp)) {
}

I find it quite a bit more elegant and semantic, and it allows avoiding defining a variable in the parent block.

If not, no worries, just thought I'd see if it might pique the interest of others.

贡献者指南

技术栈
javascriptnodejs
领域
tooling
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
3-5 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Understanding of ESLint plugin developmentFamiliarity with regular expressions
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Review the existing rules in eslint plugin unicorn to understand the pattern for adding a new rule. Look at examples like the 'prefer string slice' rule for code structure. Check the maintainer's comments for any additional requirements or preferences. Implement the rule to detect `while (match = regexp.exec(str))` and suggest `String.prototype.matchAll` with a for of loop.