sindresorhus/eslint-plugin-unicorn

`require-module-attributes`: Support `TSImportType`

Open

#2,726 创建于 2025年9月1日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)JavaScript (5,022 star) (468 fork)user submission
change requestgood for beginnerhelp wanted

描述

Description

It seems typescript doesn't allow

type A = import("foo", {})

But allows

type A = import("foo", {with: {}})

I didn't add support for it in #2725, if someone need it, it can reuse the same logic as ImportExpression

Examples

// ❌
type A = import("foo", {with: {}})

// ✅
type A = import("foo")

Additional Info

No response

贡献者指南

技术栈
typescriptjavascript
领域
toolingdeveloper experience
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
TypeScript AST knowledgeESLint rule developmentReading PR #2725
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
45
研究方向
Review the existing implementation of `require module attributes` rule and the changes made in PR #2725 for `ImportExpression`. The logic for handling `TSImportType` should mirror that of `ImportExpression` but adapted for type only imports. Focus on files like `rules/require module attributes.js` and look for how `ImportExpression` is handled. The issue provides clear examples of what should be flagged and what should be allowed.