sindresorhus/eslint-plugin-unicorn

`consistent-existence-index-check`: No rationale given for style

Open

#2,714 创建于 2025年8月6日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)JavaScript (5,022 star) (468 fork)user submission
docsgood for beginnerhelp wanted

描述

Description

This rule was introduced: https://github.com/sindresorhus/eslint-plugin-unicorn/issues/1024, and our codebase uses the style: >= 0 and < 0 rather than !== -1 or === -1. Why this is preferred should either be documented, or a alternative style option could be provided.

Examples

This potential option would invert the typical behavior of the rule.

const index = foo.indexOf('bar');

// ❌
if (index === -1) {}


// ✅
if (index < 0) {}

const index = foo.indexOf('bar');

// ❌
if (index !== -1) {}

// ✅
if (index >= 0) {}

Additional Info

No response

贡献者指南

技术栈
javascriptnodejs
领域
developer experiencedocumentation
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic JavaScriptESLint fundamentals
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
80
研究方向
Review the implementation of the `consistent existence index check` rule in the plugin source code (likely `rules/consistent existence index check.js`). Examine the rationale behind the current style (`>= 0`/`< 0` vs `!== 1`/`=== 1`). Consider adding documentation to the rule's documentation or adding a new option to allow the alternative style. Check the referenced issue #1024 for prior discussion on the rationale.