sindresorhus/eslint-plugin-unicorn

Improve `prefer-string-slice` autofix

Open

#2,505 创建于 2024年12月6日

在 GitHub 查看
 (4 评论) (1 反应) (0 负责人)JavaScript (5,022 star) (468 fork)user submission
enhancementhelp wanted

描述

unicorn/prefer-string-slice is good when all the parameters are constants, or when there is only one parameter. But when there are two parameters and they're variables, the autofixes will do things like this:

editsummary = editsummary.substr(0, editsummary.length - 2); // remove trailing comma -> editsummary = editsummary.slice(0, Math.max(0, editsummary.length - 2)); // remove trailing comma

I find the Math.max pretty hard to read. I'd prefer that it not autofix that particular sub-pattern. Any interest in adding an option to this rule so that it can be configured to skip that particular sub-pattern when autofixing?

贡献者指南

技术栈
javascript
领域
developer experiencetooling
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
active
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
JavaScriptESLint plugin developmentFamiliarity with the rule's source code
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Examine the source code of the `prefer string slice` rule in the eslint plugin unicorn repository (likely in `rules/prefer string slice.js`). Focus on the autofix logic that handles cases with two parameters. Look for existing options or patterns for skipping autofixes. Check the issue comments for any further discussion on implementation details. Review the test file for the rule to understand expected behavior and to ensure new option does not break existing tests.
Improve `prefer-string-slice` autofix · sindresorhus/eslint-plugin-unicorn#2505 | Good First Issue