sindresorhus/eslint-plugin-unicorn

`prefer-set-has`: Add a `minimumItems` array length option

Open

#2,491 创建于 2024年10月28日

在 GitHub 查看
 (1 评论) (2 反应) (0 负责人)JavaScript (5,022 star) (468 fork)user submission
enhancementhelp wanted

描述

Description

Add a minimumItems option so only arrays from a certain known size will be linted (default 0).

The rule can sometimes be too strict, using sets over arrays is usually more performant the more elements it has, and it's negligible in small numbers and readability is preferred.

Fail

minimumItems: 5

const array = [1, 2, 3, 4, 5, 6, 7];
const hasValue = value => array.includes(value);

Pass

minimumItems: 5

const array = [1, 2];
const hasValue = value => array.includes(value);

贡献者指南

技术栈
javascript
领域
toolingdeveloper experience
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
JavaScriptESLint rule basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
75
研究方向
The issue requests adding a `minimumItems` option to the `prefer set has` rule. The rule is located in `rules/prefer set has.js`. The option requires modifying the rule's `schema` property and updating the logic to check the array length against `minimumItems`. Tests should be added in the relevant test directory, and documentation in `docs/rules/prefer set has.md` should be updated. The single comment on the issue may provide additional context.
`prefer-set-has`: Add a `minimumItems` array length option · sindresorhus/eslint-plugin-unicorn#2491 | Good First Issue