sindresorhus/eslint-plugin-unicorn

Rule proposal: `no-set-duplicates`

Open

#1,559 创建于 2021年10月25日

在 GitHub 查看
 (14 评论) (7 反应) (0 负责人)JavaScript (5,022 star) (468 fork)user submission
help wantednew rule

描述

Sometimes a hardcoded Set grows large enough for it to be hard to see if there is already a value in it. One could miss that a value one wants to add is already there and add a duplicate.

This rule should at minimum report hardcoded sets of literals and consts with duplicates.

This rule may also report consecutive .add calls with same arguments (this is probably much harder to implement). Or maybe this could be a separate rule like unicorn/no-array-push-push.

Fail

const allowed = new Set([
	'foo',
	'bar',
	'buz',
	'qux',
	'bar', // ← Remove duplicate value `'bar'` from the Set
]);

Pass

const allowed = new Set([
	'foo',
	'bar',
	'buz',
	'qux',
]);

贡献者指南