sindresorhus/eslint-plugin-unicorn

`explicit-length-check`: ignore variables with non-array properties?

Open

#1,266 创建于 2021年5月12日

在 GitHub 查看
 (1 评论) (1 反应) (0 负责人)JavaScript (5,022 star) (468 fork)user submission
bughelp wantedtypes

描述

if (
  dimensions.width &&
  dimensions.height &&
  dimensions.length // violation reported by unicorn/explicit-length-check
) { }

In this example, packagingData.dimensions is an object, and length could be a string.

As a heuristic to avoid false positives with detecting length or size on variables that are not actually arrays, could we ignore variables that have non-array properties? For example, an array does not have a width property, so if we see that used, we would assume dimensions is not an array, and ignore it.

贡献者指南

技术栈
javascriptnodejs
领域
tooling
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
JavaScriptESLint rule APIAST basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
45
研究方向
Investigate the current implementation of the `explicit length check` rule in `rules/explicit length check.js`. Understand how it detects violations and consider adding logic to check if the variable has other property accesses that are not typical for arrays (e.g., `.width`, `.height`). Review any existing tests to ensure the heuristic does not introduce false negatives. The issue suggests using a heuristic: if a variable has non array properties, ignore it. Implement this and add appropriate tests.