sindresorhus/eslint-plugin-unicorn

`expiring-todo-comments` should not throw in the recommended setting

Open

#1,207 创建于 2021年4月24日

在 GitHub 查看
 (0 评论) (1 反应) (0 负责人)JavaScript (5,022 star) (468 fork)user submission
enhancementhelp wanted

描述

https://github.com/sindresorhus/eslint-plugin-unicorn/blob/b1a5f5341357f63094addd972c896c08624b73f4/index.js#L50

You don't want lint to start failing automatically on a set date, generally, so I'd suggest setting it to warn instead of error

no-warning-comments is also set to warn:

https://github.com/xojs/eslint-config-xo/blob/dd613d331eb3af44137cfbac69cc51de87b7f3f5/index.js#L180

Alternative solutions in my comment:

贡献者指南

技术栈
javascriptnodejs
领域
developer experiencetooling
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
1
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
none
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
95
研究方向
Locate the file `index.js` in the eslint plugin unicorn repository at line 50. Change the severity of the `expiring todo comments` rule from 'error' to 'warn' in the recommended config. Ensure that the change is consistent with similar rules like `no warning comments` which is set to 'warn' in eslint config xo.