sindresorhus/element-ready

Use types directly from querySelector, without copying them

开放

#32 创建于 2020年12月29日

 (0 条评论) (2 个反应) (0 位负责人)JavaScript (17 个派生)user submission
enhancementhelp wanted

仓库指标

星标
 (447 个星标)
PR 合并指标
 (30 天内没有已合并 PR)

描述

If the selector is 'a', querySelector‘s return type is be HTMLAnchorElement. To achieve the same in element-ready, we had to manually copy its types and adapt them to elementReady

Ideally, instead, we should try to “inherit” directly from the global querySelector so that, if its types are enhanced (via typed-query-selector or natively), element-ready automatically gets upgraded.

Note: We can't use Parameters<typeof querySelector> and such because it doesn't support overloads nor generics.

This has been unsuccessfully tried in #31. More info about it in that PR. A possible solution might be https://github.com/microsoft/TypeScript/issues/33185#issuecomment-526969274

贡献者指南