sindresorhus/electron-unhandled

Add a filter option

Open

#18 创建于 2020年4月1日

在 GitHub 查看
 (7 评论) (7 反应) (0 负责人)JavaScript (464 star) (27 fork)user submission
enhancementhelp wanted

描述

It would be great if we had a configurable filter function that, if defined in the options, gets called BEFORE the options.logger and showMessageBox function get called and returns true or false to decide if the error should pass or not.

That way one could filter out error messages like ERR_CONNECTION_REFUSED that are not catchable

贡献者指南

技术栈
javascriptnodejselectron
领域
desktop
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic knowledge of ElectronUnderstanding of error handling in JavaScript
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
The issue requests a filter option in the electron unhandled library. The implementation would involve adding a `filter` function to the options object that receives the error and returns a boolean. The main handler in the library should check the filter before calling `options.logger` and `showMessageBox`. Relevant code is likely in the main module file, possibly `index.js` or `unhandled.js`. The maintainer has not provided further guidance, so contributors should review the existing codebase for pattern of option handling.