sindresorhus/electron-dl

Enable an app to display a custom "interrupted" dialog

Open

#105 创建于 2020年2月13日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)JavaScript (1,206 star) (136 fork)user submission
enhancementhelp wanted

描述

Rather than just allowing the 'The download of {filename} was interrupted' system message box text to be customized, enable the app to provide a dialog box styled per the app.

Could perhaps be achieved by one of: (a) Add an 'onError' optional callback. (No "interrupted" dialog is displayed is this callback is specified.) (b) Allow a blank string to be specified as the value of 'errorMessage'. (No "interrupted" dialog is displayed if the string is ""; the "interrupted" result can be found by testing the 'state' returned by the 'done' event).

贡献者指南

技术栈
javascriptnodejs
领域
desktop
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic JavaScriptElectron framework knowledgeUnderstanding of callbacks
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
Investigate the current implementation of download error handling in electron dl. Look at the codebase to understand how the app currently displays the 'interrupted' dialog. Consider implementing option (a): adding an optional 'onError' callback that overrides the default dialog. Alternatively, option (b): allowing an empty errorMessage string to suppress the dialog and let the app handle the state. Check existing tests and documentation for guidance. Discuss with maintainers if needed.