sindresorhus/electron-context-menu

"Download" actions do not work in webviews

Open

#122 创建于 2020年10月20日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)JavaScript (1,471 star) (167 fork)user submission
bughelp wanted

描述

"Download" actions pass the webview as a window to electron-dl, but electron-dl does not support webviews. Electron-dl would need to change its specification or electron-context-menu should pass the parent window instead.

贡献者指南

技术栈
javascript
领域
desktop
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic understanding of ElectronFamiliarity with webviews
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
55
研究方向
Investigate the electron context menu source to find where download actions are triggered. Determine if the webview's window is passed incorrectly. Then examine electron dl to see if it can be modified to support webviews or if the parent window should be passed instead. The issue suggests two approaches: change electron dl's specification or modify electron context menu to pass the parent window.