sindresorhus/Plash

The new disable shortcut hook is great, I'd like a similar "pause/unpause" shortcut

Open

#154 创建于 2024年1月24日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人) (3,961 star) (157 fork)user submission
enhancementhelp wanted

描述

I use a website for plash that play video playlists as a background

The shortcut to disable/re-enable is great, but it causes my playlist position to be lost as plash does not save the current URL and always reloads to the website's home page.

I'd like a pause shortcut action that hides the plash background and pauses the renderer, and corresponding unpause that does the opposite.

Alternately, if plash could save/restore the current url when disabling/enabling that would be almost as good.

贡献者指南

技术栈
swift
领域
desktop
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Swift programmingmacOS app developmentKeyboard shortcut handling
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
Study the implementation of the existing disable shortcut in the codebase (likely in the AppDelegate or a shortcuts handler). Understand how to programmatically pause the web renderer (e.g., using WKWebView's pauseAllMediaPlayback or similar) and hide the window. Check comments on the issue for any maintainer feedback on preferred approach. The payload could be similar to the disable shortcut but toggling visibility and pausing media.