simonw/datasette

sql-formatter javascript is not now working with CloudFlare rocketloader

Open

#1,969 创建于 2022年12月23日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)Python (8,637 star) (625 fork)batch import
bughelp wantedjavascript

描述

This is probably not a bug with datasette, but I thought you might want to know, @simonw.

I noticed today that my CloudFlare proxied datasette instance lost the "Format SQL" option. I'm pretty sure it was there last week.

In the CloudFlare settings, if I turn off Rocket Loader, I get the "Format SQL" option back.

Rocket Loader works by asynchronously loading the javascript, so maybe there was a recent change that doesn't play well with the asynch loading?

I'm up to date with https://github.com/simonw/datasette/commit/e03aed00026cc2e59c09ca41f69a247e1a85cc89

贡献者指南

技术栈
javascript
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic JavaScriptKnowledge of CloudFlare Rocket Loader
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Investigate how the JavaScript for the SQL formatter is loaded in datasette. Look at the relevant commit e03aed00026cc2e59c09ca41f69a247e1a85cc89 to see if any changes were made to script loading. Check if the script has an 'async' or 'defer' attribute or if it is loaded via a dynamic import that conflicts with Rocket Loader. Consider adding a script attribute or ensuring the script loads synchronously when Rocket Loader is active.