simonw/datasette

Get rid of this `restore_working_directory` hack entirely

Open

#1,366 创建于 2021年6月7日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)Python (8,637 star) (625 fork)batch import
help wantedrefactortests

描述

That seems to have fixed it. I'd love to get rid of this restore_working_directory hack entirely.

Originally posted by @simonw in https://github.com/simonw/datasette/issues/1361#issuecomment-855308811

贡献者指南

技术栈
python
领域
backend
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
PythonDatasette internals
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
Examine the codebase for uses of `restore working directory` by searching the repository. Understand the hack's purpose by reading the linked comment in issue #1361. Determine if it can be replaced with a cleaner pattern, such as using context managers or temporary directory changes. Consider testing the change to ensure no regressions.